bump: Update TRGT to v5.0.0 - #272
Merged
Merged
Conversation
- move trgt from upstream of phasing to downstream - updated docs and DAGs - updated image manifest Still to do: - update tests - update/replace trgt coverage dropouts task
- new script runs in ~2m for 1M sites, and uses only trgt.spanning.sorted.bam and trgt_catalog as input - removed coverage_dropouts task and run within trgt task
williamrowell
requested review from
egor-dolzhenko,
holtjma,
juniper-lake and
tmokveld
December 12, 2025 16:52
egor-dolzhenko
approved these changes
Dec 12, 2025
juniper-lake
approved these changes
Dec 12, 2025
holtjma
approved these changes
Dec 12, 2025
holtjma
left a comment
holtjma
left a comment
There was a problem hiding this comment.
I mostly focused on the phasing component, and that minor flow changes looks correct to me.
…osomes, including PARs - provide ploidybed (from sawfish inputs) as input
williamrowell
force-pushed
the
bump/trgt-5
branch
from
December 18, 2025 23:28
59c913e to
b6e3415
Compare
williamrowell
requested review from
egor-dolzhenko,
holtjma and
juniper-lake
December 19, 2025 00:07
Collaborator
Author
|
Ready for a new review. |
tmokveld
approved these changes
Dec 19, 2025
tmokveld
left a comment
tmokveld
left a comment
Member
There was a problem hiding this comment.
Nice, using ploidy the dropout script logic is much clearer now!
holtjma
approved these changes
Dec 19, 2025
holtjma
left a comment
holtjma
left a comment
There was a problem hiding this comment.
Parts I'm familiar with still look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.