-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[SOT] Mark coverage and colorama as no need convert module
#76641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOT] Mark coverage and colorama as no need convert module
#76641
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR prevents the coverage and colorama libraries from entering the SOT (Symbolic Opcode Translator) evaluation frame. The change addresses issues where coverage 7.12 causes coverage's own logic to enter the eval frame, and where colorama on Windows enters the eval frame unnecessarily.
- Introduced a reusable helper function to conditionally add modules to the skip list
- Added
coverageandcoloramato the skip modules set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #76641 +/- ##
==========================================
Coverage ? 92.30%
==========================================
Files ? 1
Lines ? 13
Branches ? 0
==========================================
Hits ? 12
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7.12之前的 coverage 通过 frame.f_trace 做 coverage 检测,这种操作不会影响SOT吗 |
我不清楚之前为什么不影响,目前使用的 5.5 是完全不会影响的,7.6 开始(或者更早,我不确定什么时候开始的)就会影响 另外 7.4 引入的 |
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
coverage库在升级到 7.12 时会导致Coverage流水线里coverage包自身的插桩逻辑走到 eval framecolorama库则是当初 SOT 迁移到 Paddle repo 时调试发现 Windows 下colorama逻辑会进到 eval frame这两者都应该禁掉,因为这些库里不可能有组网逻辑