Skip to content

Conversation

@SigureMo
Copy link
Member

@SigureMo SigureMo commented Nov 26, 2025

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

  • coverage 库在升级到 7.12 时会导致 Coverage 流水线里 coverage 包自身的插桩逻辑走到 eval frame
  • colorama 库则是当初 SOT 迁移到 Paddle repo 时调试发现 Windows 下 colorama 逻辑会进到 eval frame

这两者都应该禁掉,因为这些库里不可能有组网逻辑

@SigureMo SigureMo requested a review from Copilot November 26, 2025 16:06
@paddle-bot
Copy link

paddle-bot bot commented Nov 26, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents the coverage and colorama libraries from entering the SOT (Symbolic Opcode Translator) evaluation frame. The change addresses issues where coverage 7.12 causes coverage's own logic to enter the eval frame, and where colorama on Windows enters the eval frame unnecessarily.

  • Introduced a reusable helper function to conditionally add modules to the skip list
  • Added coverage and colorama to the skip modules set

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@1d7d4c1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...hon/paddle/jit/sot/opcode_translator/skip_files.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #76641   +/-   ##
==========================================
  Coverage           ?   92.30%           
==========================================
  Files              ?        1           
  Lines              ?       13           
  Branches           ?        0           
==========================================
  Hits               ?       12           
  Misses             ?        1           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SigureMo SigureMo requested a review from DrRyanHuang November 27, 2025 15:25
@DrRyanHuang
Copy link
Contributor

DrRyanHuang commented Nov 28, 2025

coverage 库在升级到 7.12 时会导致 Coverage 流水线里 coverage 包自身的插桩逻辑走到 eval frame

7.12之前的 coverage 通过 frame.f_trace 做 coverage 检测,这种操作不会影响SOT吗

@SigureMo
Copy link
Member Author

7.12之前的 coverage 通过 frame.f_trace 做 coverage 检测,这种操作不会影响SOT吗

我不清楚之前为什么不影响,目前使用的 5.5 是完全不会影响的,7.6 开始(或者更早,我不确定什么时候开始的)就会影响

另外 7.4 引入的 COVERAGE_CORE=sysmon 会调到 co_filename="<string>" 这种代码,这个 PR 还禁不掉……

@SigureMo SigureMo merged commit 5e0e465 into PaddlePaddle:develop Nov 28, 2025
78 of 81 checks passed
@SigureMo SigureMo deleted the sot/mark-coverage-and-colorama-as-no-need-convert-module branch November 28, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants