fix: Zero values for minimum or maximum were not rendered#1087
Merged
sserrata merged 1 commit intoPaloAltoNetworks:mainfrom Feb 19, 2025
Merged
fix: Zero values for minimum or maximum were not rendered#1087sserrata merged 1 commit intoPaloAltoNetworks:mainfrom
sserrata merged 1 commit intoPaloAltoNetworks:mainfrom
Conversation
|
Visit the preview URL for this PR (updated for commit 29b609a): https://docusaurus-openapi-36b86--pr1087-sp1tyjgb.web.app (expires Thu, 20 Mar 2025 22:39:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
Member
|
Hi @c4phesua, good catch! The changes LGTM...I'll work to merge by EOD. Thanks! |
Contributor
Author
|
Thank you @sserrata |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The check for maximum and minimum values missed the zero value, which is a falsy, so it was not rendered.
Motivation and Context
I’m using this addon for my project, but it doesn’t render the minimum/maximum value. #754 was supposed to fix the issue, but it still persists, so I decided to resolve it myself.
How Has This Been Tested?
Screenshots
Types of changes
Checklist