fix: properly encode parameters #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelandresen
commented
Jul 9, 2025
| @@ -94,17 +87,9 @@ function setQueryParams(postman: sdk.Request, queryParams: Param[]) { | |||
| } | |||
| } | |||
|
|
|||
| // Handle boolean values | |||
There was a problem hiding this comment.
explanation: decodedValue is a constant value defined in Line 58 an therefore of type "string".
|
Visit the preview URL for this PR (updated for commit c3972d5): https://docusaurus-openapi-36b86--pr1202-u6e79h4f.web.app (expires Fri, 08 Aug 2025 21:45:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
|
Thanks for the fix @michaelandresen! Looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses issue #1199 (URIError when entering percent sign (%) in API Explorer) by wrapping the
decodeURIcall in atry-catchblock to gracefully handle malformed input.Motivation and Context
Without this fix, the API Explorer crashes when a percent sign (%) is entered in query or path parameters. Additionally, entering the string
"null"in path parameters also causes a crash. This update ensures the application remains stable when encountering such inputs.How Has This Been Tested?
%in query or path parameters previously caused a crash — now handled safely."null"in path parameters previously caused a crash — now handled safely.Types of Changes
Checklist