Skip to content

Fix method signature mismatch in Firewall subclass #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix method signature mismatch in Firewall subclass #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion panos/firewall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def _save_system_info(self, system_info):
self.content_version = system_info["system"]["app-version"]
self.multi_vsys = system_info["system"]["multi-vsys"] == "on"

def element(self):
def element(self, with_children=True, comparable=False):
if self.serial is None:
raise ValueError("Serial number must be set to generate element")
entry = ET.Element("entry", {"name": self.serial})
Expand Down