Draft: Use PluginMessage to allow Velocity to cancel signed chat and commands #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SessionCommandHandler is only generated for versions greater 1.19.3
|
I marked this as Ready. I'm using it on my server in production and it works perfectly fine. |
4drian3d
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some logic to send cancelled signed messages/commands to the backend server.
This is a draft implementation and could be further improved, e.g. by a config option.
There is already an open PR in Paper for this feature: PaperMC/Paper#9828
Note: I removed the version checks in SessionCommandHandler because that handler is only created for versions >= 1.19.3 (see ClientPlaySessionHandler)