[Central Station] Stardew Access Integration #1153
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… important and some decoratinos only) for use by screen readers via stardew access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've just released a beta for v1.7.0 of stardew access which will be focused on improving the support for other mods.
And I tested the beta with the central station mod, so I created this PR to ensure I'm in the right path with the changes.
To provide information to the screen reader, I've added
TileDescproperties to certain tiles which stardew access uses (here's a wiki on this). So that is all this PR changes. Although I've not yet marked the decor tiles, like benches and tables, because ATM stardew access' object tracker cannot properly navigate through group of tiles with same names (it just considers the closest one), so until that I'll keep this PR as a draft.Additionally, as I don't edit maps much, is it possible that I only check for the
TileDescproperty for a certain layer, say Building. Because right the mod is iterating though all the layers, for all the tiles (look here). Months ago when I was testing this, adding TileDesc property to different layer than the objects' just wasn't getting detected in the linked method.