Open
Conversation
- Run `rustfmt` - Change `///!` to `//!` so the lib doc shows - Move deny to warn, so it's easier to disable deny-by-default None of the changes have any functional impact on how the library works. I recommend removing `deny(warnings)` or moving it to CI, as this makes development more convenient.
Contributor
Author
|
If you don't want the rustfmt changes, I can remove them. |
Owner
|
Thanks, could you please rebase on the latest master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 things
rustfmt///!to//!so the lib doc showsNone of the changes have any functional impact on how the library works.
I recommend removing
deny(warnings)or moving it to CI, as this makesdevelopment more convenient.