(add-signal-map-filter) Added filter for SignalMapExt#78
Open
JedimEmO wants to merge 2 commits intoPauan:masterfrom
Open
(add-signal-map-filter) Added filter for SignalMapExt#78JedimEmO wants to merge 2 commits intoPauan:masterfrom
JedimEmO wants to merge 2 commits intoPauan:masterfrom
Conversation
JedimEmO
changed the title
…filter function to take &key, &value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds filter to SignalMapExt. Not sure about unstable callback functions; i.e. if a callback has non-deterministic outcome for a given key, should we keep track of items that has been filtered etc. to correctly send Removed/inserted diffs based on the new result from the filter function or not