-
-
Notifications
You must be signed in to change notification settings - Fork 60
Re-adding-people-page #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for pauseai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Issue: #533 |
|
|
There's a 500 internal error in /people i don't know how to fix. |
|
I don't understand much of the changes i did, the code is basically the same as before when the page was running |
|
No 500 here in local dev on your branch, works fine @Pato-desu . I'm assuming you're missing the Airtable token. However, I do see a different issue. We currently use the old volunteers table that has been migrated to a new one, but in the migration the photo's have been lost. So we have to move the photos. |
|
Yeah, i know. Same with titles. Its in the bullet TODO points |
|
From previous experience "no 500 here in local dev" does not predict no 500 in the wild, alas. (Which is what we have in the preview, to be clear.) Was that using the Netlify CLI @joepio ? No need to invest, just a y/n I can look at this issue. Also have opinions on some of the "where shall we manage the relevant data?" questions the todos imply. |
what data? |
|
@anthonybailey I tracked down the error to this line in paraglide bc "window" is defined in Deno but "window.location" seems to be undefined. But I have no idea why "setLocale" would be called in the first place https://github.com/opral/monorepo/blob/b951344b1f976a0f34729909d659c1fa2de6ae88/inlang/packages/paraglide/paraglide-js/src/compiler/runtime/set-locale.js#L112 |
|
And it might also mean that we can't serve any dynamic pages whatsoever at the moment? We don't have any non-API routes in production afaik |
We store names and emails and team assignments in a mess of old and new Airtables. In general, we've had some success representing structured data that changes over time and is presented on website pages as JSON in the source-controlled repository rather than in a database. Allows pages to be static, etc. |
|
So, I don't know what you guys did but it was working today for me so thanks for that. |
|
Uhh, I don't think anything changed and I still get a 500 on /people |
|
@Wituareard I may should be doing something on my side. I stopped trying to do so because what usually happens to me is: I sometimes get 500 error, then I reload, I get the fallback data, then i reload, and get the actual people. Could this be something that will get fixed once public? |
|
That is not likely, but given our lack of clarity anything is possible. (I observe similar behaviour with the page on the preview site. First fetch from a sufficiently new client is always a 500. Future attempts succeed very consistently. No correlated problems on other pages.) |
|
All my comments were about the preview, sorry, I thought I clarified it but I only did to Joep in his DMs. |
Testing first-request behavior on cold start
Investigation Update: 500 Error on
|
|
This all matches with the other issue where we saw a 500 in production after introducing a dynamic route for our statement: #370 (and PR #379) It overlaps with issues we had with preview-all-locales (many notes from PR #325) but is distinct in that for the latter case I can partially reproduce some problems locally. I can see quick fixes, but give me a few more hours and there's a decent chance everything finally untangles much more. |
- Creates /api/deno-version endpoint configured for edge runtime - Reports Deno version, window object status, and window.location availability - Will help identify differences between local (Deno 2.2.4) and production environments - Related to investigation of 500 errors on dynamic routes (#538, #540)
Changes isServer detection from build-time constant to runtime check. Problem: - import.meta.env.SSR evaluates to false in edge functions - Bundler optimizes away !isServer guard as dead code - Code tries to access window.location.href in Netlify's Deno runtime - Netlify provides window object but window.location is undefined - Crash: "Cannot read properties of undefined (reading 'href')" Solution: - Use runtime check: typeof window === "undefined" || typeof window.location === "undefined" - Correctly identifies edge functions as server-side (isServer = true) - Prevents bundler from removing the guard - Works in Node.js, Netlify Edge (Deno 2.3.1), and browsers Also removes importRuntimeWithoutVite() workaround - no longer needed with runtime isServer check that works in all contexts. Related: #538, #540
|
Closing this PR was probably accidental @anthonybailey ? |
|
It seems to work, not getting any errors on my side |
|
@anthonybailey Do you think we can merge? |
|
I am just bringing the fix from main now. If I closed this it was in error. |
|
I've already merged it |
|
ok, i'll move the task list left to the issue itself |

No description provided.