Skip to content

Conversation

Dimi1010
Copy link
Collaborator

No description provided.

@Dimi1010 Dimi1010 marked this pull request as ready for review September 19, 2025 06:26
@Dimi1010 Dimi1010 requested a review from seladb September 19, 2025 06:26
@seladb
Copy link
Member

seladb commented Sep 19, 2025

@Dimi1010 we can merge this PR, but I think we need to archive / delete this repo because we can't use it...

@Dimi1010
Copy link
Collaborator Author

@Dimi1010 we can merge this PR, but I think we need to archive / delete this repo because we can't use it...

Don't archive it yet. I have an idea about using the auto update workflow script to generate PRs from this repo to the main repo to keep them in sync.

Comment on lines -29 to -34
#ifdef _WIN32
#include <winsock2.h>
#pragma comment(lib, "ws2_32.lib")
#else
#include <arpa/inet.h>
#endif
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure some tests don't compile / pass on all platforms. This is something we need to fix if we really want to use this fork

Comment on lines -29 to -34
#ifdef _WIN32
#include <winsock2.h>
#pragma comment(lib, "ws2_32.lib")
#else
#include <arpa/inet.h>
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure some tests don't compile / pass on all platforms. This is something we need to fix if we really want to use this fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants