-
Notifications
You must be signed in to change notification settings - Fork 0
Copy changes from pcapplusplus repo. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@Dimi1010 we can merge this PR, but I think we need to archive / delete this repo because we can't use it... |
Don't archive it yet. I have an idea about using the auto update workflow script to generate PRs from this repo to the main repo to keep them in sync. |
#ifdef _WIN32 | ||
#include <winsock2.h> | ||
#pragma comment(lib, "ws2_32.lib") | ||
#else | ||
#include <arpa/inet.h> | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure some tests don't compile / pass on all platforms. This is something we need to fix if we really want to use this fork
#ifdef _WIN32 | ||
#include <winsock2.h> | ||
#pragma comment(lib, "ws2_32.lib") | ||
#else | ||
#include <arpa/inet.h> | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure some tests don't compile / pass on all platforms. This is something we need to fix if we really want to use this fork
No description provided.