-
Notifications
You must be signed in to change notification settings - Fork 6
#79---press-and-hold-listening-mode #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johncrawley
wants to merge
25
commits into
main
Choose a base branch
from
#79---press-and-hold-listening-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter interruption, static glow remains on momentary pause, state engine does not wait for button release to send transcription.
…not submitting transcriptions in momentary listening mode.
…ode (paused or engaged) currently doesn't send transcripts.
…after response has ended.
…g stop-requested, instead of stop when momentary pause is invoked. Still not sending audio, and double transcription is generated.
…broken when momentary mode is enabled.
…g accumulation or transcription.
…ssed, and added new momentary icons.
…and ensuring that UI elements don't fade when momentary mode is active in immersive mode.
…ule using ButtonHelper, and removed redundant methods from ButtonHelper.
…ry update. Newly added touch listeners have also been added, but 'touchend' is only detected on every other press.
…th momentary listening long-click on desktop.
…d with both click events and touch events.
Contributor
Author
|
I've added new messages to the en locale only, because I'm not sure if those strings are entirely suitable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#79
Tested so far on Android and Firefox on Linux.
click/touch and hold the call button for momentary mode to be enabled
releasing will cause the microphone to be muted
clicking while the microphone is muted will return to standard operation.
in immersive mode, the screen icons do not fade away while momentary mode is enabled and active.