Skip to content
This repository was archived by the owner on Sep 26, 2019. It is now read-only.

Conversation

@mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Aug 12, 2019

PR description

Use git show-ref to retrieve the hash associate with a git reference. This handles the case where the current branch reference is stored in .git/packed-refs but not .git/refs/heads.

@mbaxter mbaxter requested a review from shemnon August 12, 2019 22:22
@shemnon
Copy link
Contributor

shemnon commented Aug 12, 2019

This create a hard requirement on git being present to do a build. Many of our build containers do not have git present.

Can the old method be kept as a primary and the show-ref version be attempted when it fails?

@ajsutton
Copy link
Contributor

For the record, I believe we've added git to all our build containers now. The latest version of the release plugin required it. But we're planning to remove the release plugin entirely so maybe would be useful to make it work with or without git if it's not too hard.

@mbaxter
Copy link
Contributor Author

mbaxter commented Aug 12, 2019

Cool, that makes sense. Will update 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants