This repository was archived by the owner on Sep 26, 2019. It is now read-only.
Treat discovery peer with unknown endpoint as unknown #1942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update discovery logic to consider a peer with an unknown discovery endpoint to be unknown regardless of whether we've encountered a peer with the same node id before. This makes the discovery logic more forgiving in the face of node restarts.
If
nodeAbonds withnodeB, thennodeBcrashes and restarts with a different ip address or listening port,nodeAwould previously continue trying to communicate withnodeBat its original address. With these changes,nodeAwill now treat the resurrectednodeBas a new peer and communicate with it on its updated endpoint.Opening this as a draft PR to get input on whether people think this is a good idea.