Skip to content

Conversation

cindyhfls
Copy link

Making individual masks for HCP output followed from this: https://neurostars.org/t/differences-in-dcan-derivatives-and-hcp-ya-outputs/30631/2

Changes proposed in this pull request

Documentation that should be reviewed

from DCAN-bold-processing to get subject-specific eroded masks for HCP outputs
replace default mask with masks made for individuals
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (68caadf) to head (2211cda).

Files with missing lines Patch % Lines
xcp_d/ingression/utils.py 6.66% 14 Missing ⚠️
xcp_d/ingression/hcpya.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   78.63%   78.46%   -0.18%     
==========================================
  Files          59       59              
  Lines        7308     7326      +18     
  Branches     1106     1108       +2     
==========================================
+ Hits         5747     5748       +1     
- Misses       1273     1290      +17     
  Partials      288      288              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cindyhfls
Copy link
Author

This needs the installation of fsl: https://nipype.readthedocs.io/en/latest/users/examples/fmri_fsl.html

@tsalo
Copy link
Member

tsalo commented Oct 15, 2024

I recently managed to remove FSL from the XCP-D Docker image and I'm not planning to add it back in. As far as I can tell, you can accomplish everything you're currently doing with fslmaths with Python tools. I would recommend using Python libraries, as the other ingression functions do.

@cindyhfls
Copy link
Author

cindyhfls commented Oct 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants