test: add comprehensive test coverage for Owner single-step access control #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrol Adds extensive test coverage for the single-step ownership transfer pattern, adapted to work with the current library implementation where access control is enforced by facets, not libraries. - **`test/access/Owner/OwnerFacet.t.sol`** (19 tests) - Immediate ownership transfer functionality - Ownership renouncement behavior - Access control enforcement - Gas optimization benchmarks - Documents known renouncement error inconsistency - **`test/access/Owner/LibOwner.t.sol`** (25 tests) - Library internal functions - Storage slot verification - Event emission testing - Fuzz testing for robustness - Verifies library doesn't enforce access control (facet's responsibility) - Includes TODO comments for 3 tests that will change when renouncement becomes irreversible - `test/access/Owner/harnesses/OwnerFacetHarness.sol` - Exposes internal state for testing - `test/access/Owner/harnesses/LibOwnerHarness.sol` - Exposes library functions - ✅ Ownership transfer (immediate effect) - ✅ Ownership renouncement (transfer to zero address) - ✅ Sequential ownership changes - ✅ Access control verification - ✅ Event emission - ✅ Edge cases (self-transfer, renounced owner behavior) - ✅ Storage slot consistency - ✅ Gas consumption benchmarks - ✅ Fuzz testing with random addresses 1. **Renouncement is currently reversible** (to be fixed): The library allows `transferOwnership` after renouncement. Tests include TODO comments for updating when this is fixed. 2. **Error inconsistency**: After renouncement, `OwnerFacet` returns a generic `OwnerUnauthorizedAccount` error instead of a specific error. This is preserved for backwards compatibility. The maintainer has moved to a clean separation of concerns where libraries only handle state management and facets enforce access control. This makes libraries more flexible and composable. Tests verify this architecture by confirming the library doesn't check `msg.sender`.
Coverage Report
Last updated: Sun, 26 Oct 2025 06:38:46 GMT for commit |
Contributor
|
Thanks! |
Collaborator
Author
|
I haven't yet had the time to diagnose why the test job is failing... @mudgen is it ok to merge with those failures? |
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
test: add comprehensive test coverage for Owner single-step access control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117
Adds extensive test coverage for the single-step ownership transfer pattern, adapted to work with the current library implementation where access control is enforced by facets, not libraries.
test/access/Owner/OwnerFacet.t.sol(19 tests)test/access/Owner/LibOwner.t.sol(25 tests)test/access/Owner/harnesses/OwnerFacetHarness.sol- Exposes internal state for testingtest/access/Owner/harnesses/LibOwnerHarness.sol- Exposes library functions✅ Ownership transfer (immediate effect)
✅ Ownership renouncement (transfer to zero address)
✅ Sequential ownership changes
✅ Access control verification
✅ Event emission
✅ Edge cases (self-transfer, renounced owner behavior)
✅ Storage slot consistency
✅ Gas consumption benchmarks
✅ Fuzz testing with random addresses
Renouncement is currently reversible (to be fixed): The library allows
transferOwnershipafter renouncement. Tests include TODO comments for updating when this is fixed.