[TESTING] : Add test for ERC165 Facet & Lib #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for compose-diamonds pending review.Visit the deploys page to approve it
|
Coverage Report
Last updated: Tue, 02 Dec 2025 00:05:55 GMT for commit |
Gas ReportNo gas usage changes detected between All functions maintain the same gas costs. ✅ Last updated: Tue, 02 Dec 2025 00:06:39 GMT for commit |
Contributor
|
@AnInsaneJimJam Thanks for submitting this! The formatting check failed. Please format your code by running |
Contributor
Author
|
Added the formatting. Should pass the test now @mudgen |
Contributor
|
@AnInsaneJimJam Great! Good, job, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added comprehensive test coverage for ERC165 Facet and Library
Changes Made
Test Files Created
test/interfaceDetection/ERC165/ERC165Facet.t.sol
test/interfaceDetection/ERC165/LibERC165.t.sol
Harness Contracts Created
test/interfaceDetection/ERC165/harnesses/ERC165FacetHarness.sol
test/interfaceDetection/ERC165/harnesses/LibERC165Harness.sol
Solves #217