Skip to content

Conversation

Starkku
Copy link
Contributor

@Starkku Starkku commented Sep 3, 2025

@Metadorius

  • Makes lower bound check of health threshold checks (weapon, warhead, crit) exclusive e.g equal to it does not satisfy the condition. This allows for creating distinct ranges for weapon/warhead eligibility e.g no overlapping.
  • Ignore health threshold checks for objects with zero health. They are not relevant consideration for current health checks (other checks filter out unalive objects), if need to consider them in future appears, conditions can be added then and there.

Migration notice is currently absent due to uncertainty about where to place it.

@Starkku Starkku added the Minor Minor feature and/or fix, not a lot of changes or they are not significant label Sep 3, 2025
Copy link

github-actions bot commented Sep 3, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Starkku Starkku force-pushed the feature/health-thresholds-again branch from 50990ad to 7de3494 Compare September 3, 2025 13:15
@Starkku Starkku added No Documentation Needed No documentation needed whatsoever Minor Minor feature and/or fix, not a lot of changes or they are not significant and removed Minor Minor feature and/or fix, not a lot of changes or they are not significant labels Sep 11, 2025
@Coronia Coronia merged commit 693924e into Phobos-developers:develop Sep 13, 2025
15 checks passed
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor feature and/or fix, not a lot of changes or they are not significant No Documentation Needed No documentation needed whatsoever
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants