New 190xx ScriptType actions that are masks of existing actions that used indexes as arguments

[FS-21]

• These actions are "masks" of existing actions:
  These actions translate IDs into indices while preserving the original action values. The reason for using these masks is that some ScriptType actions rely on fixed indices rather than ID labels (basically because all arguments are readed as integers). When these lists change, there's a high probability of breaking the original index of the pointed element.
  So for example if is readed:
  x=19046,GAPOWR,LeastThreat
  It will be translated into:
  x=46,0
  The modder won't have to calculate the index every time because is calculated the first time the scenario is readed.

• Yes, arguments now support reading strings (if the action supports it that currently are these cases).

19017 Change Script

• Similar to action 17, but uses a string ID from the [ScriptTypes] list instead of an index.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19017,ID        ; text

19018 Change TeamType

• Similar to action 18, but uses a string ID from the [TeamTypes] list instead of an index.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19018,ID        ; text

19020 Change House

• Similar to action 20, but uses a string ID from the [Countries] list instead of an index.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19020,ID        ; text

19024 Play Speech

• Similar to action 24 (when the respective PR gets merged), but uses a string ID from the [DialogList] list instead of an index.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19024,ID        ; text

19025 Play Sound

• Similar to action 25, but uses a string ID from the [SoundList] list instead of an index.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19025,ID        ; text

19027 Play Theme

• Similar to action 27, but uses a string ID from the [Themes] list instead of an index.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19027,ID        ; text

19051 Play Animation

• Similar to action 51, but uses a string ID from the [Animations] list instead of an index.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19051,ID        ; text

19046 Attack Enemy Structure

• Similar to action 46, but uses a string ID from the [BuildingTypes] list instead of an index.
• The last parameter is the BwP. Check below the possible strings.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19046,ID,BwP    ; text

BwP values	Description
LeastThreat	Index of the instance of the building with least threat
HighestThreat	Index of the instance of the building with highest threat
Nearest	Index of the instance of the building which is nearest
Farthest	Index of the instance of the building which is farthest

More BwP information in https://modenc.renegadeprojects.com/ScriptTypes/ScriptActions
For this action to work in multiplayer - you need to use a version of [Script Actions information at Modenc](https://modenc.renegadeprojects.com/ScriptTypes/ScriptActions).

19047 Move To Enemy Structure

• Similar to action 47, but uses a string ID from the [BuildingTypes] list instead of an index.
• The last parameter is the BwP. Check the table of the action 19046.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19047,ID,BwP    ; text

19056 Chronoshift TaskForce To Structure

• Similar to action 56, but uses a string ID from the [BuildingTypes] list instead of an index.
• The last parameter is the BwP. Check the table of the action 19046.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19056,ID,BwP    ; text

19058 Move To Friendly Structure

• Similar to action 58, but uses a string ID from the [BuildingTypes] list instead of an index.
• The last parameter is the BwP. Check the table of the action 19046.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=19058,ID,BwP    ; text

[github-actions]

Nightly build for this pull request:

• compiled-dll-9c00083bc27ebf82dcca0ec1a4640c51f46bfbcd.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[FS-21]

Some use-case examples:
[BuildingTypes]
...
1=GAREFN ; Allied Refinery
...

Example of Index of the building with "least threat":
x=46,1
Now can be translated as:
x=19046,GAREFN,LeastThreat

Example of Index of the building with "highest threat":
x=46,65537
Now can be translated as:
x=19046,GAREFN,HighestThreat

Example of Index of the building with is "nearest":
x=46,131073
Now can be translated as:
x=19046,GAREFN,Nearest

Example of Index of the building with is "farthest":
x=46,196609
Now can be translated as:
x=19046,GAREFN,Farthest

Example playing an animation:
[Animations]
...
11=GUNFIRE
...

x=51,11
Now can be translated as:
x=19051,GUNFIRE

The basic idea is that now you can move any element in those lists and always will point to the desired object.

[fagonghaiwo]

19020 cause a FE
EIP: 6A0B167B
Module Phobos.dll base address : 0x6A070000.

[handama]

As far as I know, although it’s called “change house”, action 20 uses the [Countries] index.

[FS-21]

Fixed (I forgot testing this 19020 so sorry!). Now it finds the right House index.
The problem was that the argument was readed until a space was found, now reads the line until the end. so for excample if you have a house called "Nod APCs" now reads "Nod APCs" instead of only "Nod".

handama, not very sure about your comment about Countries:

[handama]

test_map_19020.zip

For a SP map like this, which uses new houses instead of default ones auto-created by map editor (e.g. vanilla RA2 campaigns), the house index and country index does not match. In this test map, the correct param to change to BadGuy1 House is [15], while the result of HouseClass::FindIndexByName is [1].

[FS-21]

Right! Now I see the problem (I found a similar case but in my mod):

I'll submit a fix soon.

[FS-21]

Changed the 19020 behavior and now should read country names instead of house names.

[FS-21]

Ah yes, for the tests don't use WAE (even if you edit the ScriptActions.ini file) because this editor doesn't support writing text in the parameters TextBox and will ruin these scripts when you save it with a "-1" value (think parameters were always integers so why would they think about strings),
Only handwritten tests are recommended.

[secsome]

Can be merged after testing and doing those cleanups.

[secsome]

Those useless comments can be removed imo

[FS-21]

Including the explanation or only the old code?

[secsome]

LGTM