Skip to content

Fix uninitialized build warning #6321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2025
Merged

Fix uninitialized build warning #6321

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46830ca
Fix uninitialized build warning
MaximSmolskiy Aug 17, 2025
5831492
Fix review issue
MaximSmolskiy Aug 24, 2025
bd86c57
Fix
MaximSmolskiy Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions recognition/include/pcl/recognition/impl/implicit_shape_model.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ pcl::features::ISMVoteList<PointT>::findStrongestPeaks (
{
// find best peak with taking into consideration peak flags
double best_density = -1.0;
Eigen::Vector3f strongest_peak;
Eigen::Vector3f strongest_peak = Eigen::Vector3f::Constant (-1);
int best_peak_ind (-1);
int peak_counter (0);
for (int i = 0; i < NUM_INIT_PTS; i++)
Expand All @@ -188,7 +188,8 @@ pcl::features::ISMVoteList<PointT>::findStrongestPeaks (
}
}

if( peak_counter == 0 )
if( best_density == -1.0 || strongest_peak == Eigen::Vector3f::Constant (-1) ||
best_peak_ind == -1 || peak_counter == 0 )
break;// no peaks

pcl::ISMPeak peak;
Expand Down