Repository navigation
PABotBase2_MessageDumper: fix copy-pasted LOG_LABEL_H32/I32 labels - #1559
Merged
Merged
Conversation
The LOG_LABEL_H32 and LOG_LABEL_I32 cases in tostr(const MessageHeader*) both printed the label string of the U32 case, so hex and signed 32-bit log labels were mislabeled in the message dump output. Print the correct label for each case.
Mysticial
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LOG_LABEL_H32andLOG_LABEL_I32cases intostr(const MessageHeader*)both printed the label string of the U32 case, so hex and signed 32-bit log labels were mislabeled in the message dump output.This is a string-only change to the two affected case bodies; the
U32case is untouched.