Skip to content

fix: rfq params cleanup #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sahilgat02 merged 2 commits into from
Jan 13, 2026
Merged

fix: rfq params cleanup #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b19784b
bump version
sahilgat02 Jan 12, 2026
9140df8
fixes
sahilgat02 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions py_clob_client/rfq/rfq_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ def parse_rfq_requests_params(params: Optional[GetRfqRequestsParams] = None) ->

# Single value fields (convert snake_case to camelCase)
single_fields = [
("user_address", "userAddress"),
("state", "state"),
("size_min", "sizeMin"),
("size_max", "sizeMax"),
Expand All @@ -107,8 +106,6 @@ def parse_rfq_requests_params(params: Optional[GetRfqRequestsParams] = None) ->
# Array fields (keep as lists; let urlencode(doseq=True) expand them)
if params.request_ids:
result["requestIds"] = params.request_ids
if params.states:
result["states"] = params.states
if params.markets:
result["markets"] = params.markets

Expand All @@ -135,7 +132,6 @@ def parse_rfq_quotes_params(params: Optional[GetRfqQuotesParams] = None) -> Dict

# Single value fields (convert snake_case to camelCase)
single_fields = [
("user_address", "userAddress"),
("state", "state"),
("size_min", "sizeMin"),
("size_max", "sizeMax"),
Expand All @@ -159,8 +155,6 @@ def parse_rfq_quotes_params(params: Optional[GetRfqQuotesParams] = None) -> Dict
result["quoteIds"] = params.quote_ids
if params.request_ids:
result["requestIds"] = params.request_ids
if params.states:
result["states"] = params.states
if params.markets:
result["markets"] = params.markets

Expand Down
38 changes: 13 additions & 25 deletions py_clob_client/rfq/rfq_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"""

from dataclasses import dataclass, field
from typing import List, Optional, Any
from typing import List, Optional, Any, Literal
from enum import Enum


Expand Down Expand Up @@ -176,19 +176,13 @@ class GetRfqRequestsParams:
"""

request_ids: Optional[List[str]] = None
"""Filter by specific request IDs."""
"""Filter by specific request IDs (query param: requestIds; repeatable)."""

user_address: Optional[str] = None
"""Filter by user address."""

states: Optional[List[str]] = None
"""Filter by multiple states."""

state: Optional[str] = None
state: Optional[Literal["active", "inactive"]] = None
"""Single state filter ("active" or "inactive")."""

markets: Optional[List[str]] = None
"""Filter by market condition IDs."""
"""Filter by market condition IDs (query param: markets; repeatable)."""

size_min: Optional[float] = None
"""Minimum size filter."""
Expand All @@ -208,10 +202,10 @@ class GetRfqRequestsParams:
price_max: Optional[float] = None
"""Maximum price filter."""

sort_by: Optional[str] = None
sort_by: Optional[Literal["price", "expiry", "size", "created"]] = None
"""Field to sort by."""

sort_dir: Optional[str] = None
sort_dir: Optional[Literal["asc", "desc"]] = None
"""Sort direction: "asc" or "desc"."""

limit: Optional[int] = None
Expand All @@ -230,22 +224,16 @@ class GetRfqQuotesParams:
"""

quote_ids: Optional[List[str]] = None
"""Filter by specific quote IDs."""
"""Filter by specific quote IDs (query param: quoteIds; repeatable)."""

request_ids: Optional[List[str]] = None
"""Filter by request IDs."""

user_address: Optional[str] = None
"""Filter by user address."""
"""Filter by request IDs (query param: requestIds; repeatable)."""

states: Optional[List[str]] = None
"""Filter by multiple states."""

state: Optional[str] = None
"""Single state filter."""
state: Optional[Literal["active", "inactive"]] = None
"""Single state filter ("active" or "inactive")."""

markets: Optional[List[str]] = None
"""Filter by market condition IDs."""
"""Filter by market condition IDs (query param: markets; repeatable)."""

size_min: Optional[float] = None
"""Minimum size filter."""
Expand All @@ -265,10 +253,10 @@ class GetRfqQuotesParams:
price_max: Optional[float] = None
"""Maximum price filter."""

sort_by: Optional[str] = None
sort_by: Optional[Literal["price", "expiry", "created"]] = None
"""Field to sort by."""

sort_dir: Optional[str] = None
sort_dir: Optional[Literal["asc", "desc"]] = None
"""Sort direction: "asc" or "desc"."""

limit: Optional[int] = None
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name="py_clob_client",
version="0.34.4",
version="0.34.5",
author="Polymarket Engineering",
author_email="engineering@polymarket.com",
maintainer="Polymarket Engineering",
Expand Down