fix(cli): infer logs page size from API response (#8002)#21711
Open
alighazi288 wants to merge 1 commit intoPrefectHQ:mainfrom
Open
fix(cli): infer logs page size from API response (#8002)#21711alighazi288 wants to merge 1 commit intoPrefectHQ:mainfrom
alighazi288 wants to merge 1 commit intoPrefectHQ:mainfrom
Conversation
Merging this PR will not alter performance
Comparing |
- Removes hard-coded `LOGS_DEFAULT_PAGE_SIZE = 200` in flow-run logs CLI - Dynamically discovers page size by passing `limit=None` on the first request - Refactors `--tail` logic to buffer pages in `TIMESTAMP_DESC` order to avoid offset math errors - Adds test to verify pagination respects custom `PREFECT_SERVER_API_DEFAULT_LIMIT` Signed-off-by: alighazi288 <51366992+alighazi288@users.noreply.github.com>
36ebf00 to
275ca0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the dynamic logs pagination logic requested in #8002
LOGS_DEFAULT_PAGE_SIZE = 200in flow-run logs CLIlimit=Noneon the first request--taillogic to buffer pages inTIMESTAMP_DESCorder to avoid offset math errorsPREFECT_SERVER_API_DEFAULT_LIMITChecklist
mint.json.