chore: remove deprecated dev CLI subgroup and docker logic (#20607)#22507
chore: remove deprecated dev CLI subgroup and docker logic (#20607)#22507ChidiebereNjoku wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b0146af0e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,691 +0,0 @@ | |||
| import hashlib | |||
There was a problem hiding this comment.
Restore dockerutils until callers are migrated
Deleting this module breaks every remaining import of prefect.utilities.dockerutils: the reviewed tree still imports it from src/prefect/docker/docker_image.py, src/prefect/deployments/runner.py, src/prefect/_internal/buildx.py, and multiple integration workers. In those contexts, simply importing prefect.docker.DockerImage or using Docker-backed deployments/workers will raise ModuleNotFoundError before any replacement logic can run, so the shared helpers need to remain or all callers need to be moved first.
Useful? React with 👍 / 👎.
| @@ -1,85 +0,0 @@ | |||
| --- | |||
There was a problem hiding this comment.
Remove deleted dev API page from navigation
This page is deleted, but docs/docs.json still registers v3/api-ref/python/prefect-cli-dev at line 1237. With that navigation entry left behind, the published docs point to a missing API reference page after this change, so the docs nav/redirects need to be updated when removing the generated page.
Useful? React with 👍 / 👎.
Merging this PR will not alter performance
Comparing Footnotes
|
desertaxle
left a comment
There was a problem hiding this comment.
Thanks for opening a PR @ChidiebereNjoku! Codex's review comments and the CI failures will need to be resolved before we can consider merging. Please request another review from me when you think it's ready.
Closes #20607
Overview
As outlined in the linked issue, the
devCLI subgroup is largely unused in modern contribution workflows and still references deprecated-devDocker repository naming conventions.Modifications made in this PR:
src/prefect/cli/dev.pyand cleanly unregistered thedev_appfromsrc/prefect/cli/_app.py.-devdocker naming logic fromsrc/prefect/utilities/dockerutils.py.tests/cli/test_dev.py), documentation (docs/v3/api-ref/python/prefect-cli-dev.mdx), and thescripts/build-all-dev-imageshelper script.Checklist
<link to issue>"mint.json.