Skip to content

Apply persistent rules when processes start#21

Merged
PrimeBuild-pc merged 2 commits into
mainfrom
codex/persistent-rules-auto-apply
May 22, 2026
Merged

Apply persistent rules when processes start#21
PrimeBuild-pc merged 2 commits into
mainfrom
codex/persistent-rules-auto-apply

Conversation

@PrimeBuild-pc
Copy link
Copy Markdown
Owner

@PrimeBuild-pc PrimeBuild-pc commented May 22, 2026

Summary

  • add PersistentRuleAutoApplyService to apply existing enabled persistent rules from process discovery/start events
  • wire ProcessMonitorManagerService snapshot and process-start paths to the coordinator
  • add per-PID/rule-signature cooldown and cleanup on process exit/missing snapshots
  • add app setting ApplyPersistentRulesOnProcessStart defaulting to true

Safety

  • runtime-only while ThreadPilot is running; no service, registry, IFEO, installer, version, or tag changes
  • no rule creation or editor changes
  • failures are logged and returned without refresh-loop crashes or UI notification spam
  • protected-process statuses use persistent-rules-safe wording

Validation

  • dotnet test "ThreadPilot_1.sln" --configuration Release --no-restore
  • Passed: 367, Failed: 0, Skipped: 0

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 22, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 69.80198% with 61 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Services/PersistentRuleAutoApplyService.cs 78.28% 21 Missing and 12 partials ⚠️
Services/ProcessMonitorManagerService.cs 40.90% 24 Missing and 2 partials ⚠️
Services/PersistentRulesEngine.cs 66.66% 0 Missing and 1 partial ⚠️
Services/ServiceConfiguration.cs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@PrimeBuild-pc PrimeBuild-pc marked this pull request as ready for review May 22, 2026 10:29
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@PrimeBuild-pc PrimeBuild-pc merged commit c82f246 into main May 22, 2026
3 checks passed
@PrimeBuild-pc PrimeBuild-pc deleted the codex/persistent-rules-auto-apply branch May 22, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants