refactor: clean up timezone boundaries, add goal auto-progress sync, style error UI, secure user auth, improve accessibility, and optimize performance [tested]

e2e/dashboard-widgets.spec.js

@@ -124,7 +124,7 @@
   await expect(page.getByRole("heading", { name: "Dashboard" })).toBeVisible({ timeout: 30000 });
   await expect(page.getByRole("heading", { name: "Your Commits" })).toBeVisible({ timeout: 10000 });
   await expect(page.getByRole("heading", { name: "PR Analytics" })).toBeVisible({ timeout: 10000 });
-  await expect(page.getByRole("heading", { name: "Weekly Goals" })).toBeVisible({ timeout: 10000 });
+  await expect(page.getByRole("heading", { name: "Goals" })).toBeVisible({ timeout: 10000 });
   await expect(page.getByText("Make 10 commits")).toBeVisible({ timeout: 10000 });
 });
 
@@ -155,14 +155,14 @@
   await expect(page.getByRole("heading", { name: "Dashboard" })).toBeVisible({ timeout: 30000 });
   await page.getByLabel("Goal title").fill("Ship one PR");
   await page.getByLabel("Target").fill("1");
-  await page.getByLabel("Unit").fill("PR");
+  await page.getByLabel("Unit").selectOption("prs");
   await page.getByRole("button", { name: "Add goal" }).click();
 
   await expect.poll(() => goalPosts, { timeout: 15000 }).toHaveLength(1);
   expect(goalPosts[0]).toMatchObject({
     title: "Ship one PR",
     target: 1,
-    unit: "PR",
+    unit: "prs",
   });
 });
 

src/app/api/goals/route.ts

@@ -179,4 +179,4 @@ try {
   if (error) return Response.json({ error: error.message }, { status: 500 });
 
   return Response.json({ goal }, { status: 201 });
-}
+}

src/app/api/goals/sync/route.ts

@@ -0,0 +1,109 @@
+import { getServerSession } from "next-auth";
+import { authOptions } from "@/lib/auth";
+import { supabaseAdmin } from "@/lib/supabase";
+
+export const dynamic = "force-dynamic";
+
+/**
+ * Returns Monday 00:00:00 local time of the current week as a full ISO string.
+ *
+ * Fix for Bug 2 (Sunday + timezone):
+ * - Uses `const diff = day === 0 ? -6 : 1 - day` so Sunday correctly resolves
+ *   to the *previous* Monday, not the *next* one.
+ * - Returns a full ISO timestamp instead of `.slice(0, 10)` to avoid the UTC
+ *   date-shift bug (matching the approach already used in `getPeriodStart()`).
+ */
+function currentWeekStart(): string {
+  const now = new Date();
+  const day = now.getUTCDay();
+  const diff = day === 0 ? -6 : 1 - day; // Monday = 0 offset; Sunday = -6
+  const monday = new Date(now);
+  monday.setUTCDate(now.getUTCDate() + diff);
+  monday.setUTCHours(0, 0, 0, 0);
+  return monday.toISOString();
+}
+
+/** Returns Sunday 23:59:59.999 of the current week as a full ISO string. */
+function currentWeekEnd(): string {
+  const now = new Date();
+  const day = now.getUTCDay();
+  const diff = day === 0 ? 0 : 7 - day; // Sunday of this week
+  const sunday = new Date(now);
+  sunday.setUTCDate(now.getUTCDate() + diff);
+  sunday.setUTCHours(23, 59, 59, 999);
+  return sunday.toISOString();
+}
+
+const GITHUB_API = "https://api.github.com";
+
+export async function POST() {
+  const session = await getServerSession(authOptions);
+  if (!session?.accessToken || !session.githubId || !session.githubLogin) {
+    return Response.json({ error: "Unauthorized" }, { status: 401 });
+  }
+
+  // ── 1. Fetch user from DB ─────────────────────────────────────────────────
+  const { data: user } = await supabaseAdmin
+    .from("users")
+    .select("id")
+    .eq("github_id", session.githubId)
+    .single();
+
+  if (!user) return Response.json({ error: "User not found" }, { status: 404 });
+
+  const weekStart = currentWeekStart();
+  const weekEnd = currentWeekEnd();
+
+  // ── 2. Fetch all commit-based goals for this week ─────────────────────────
+  // Fix for Bug 1: column is `period_start` (full ISO timestamp), not `week_start`.
+  // Use a range filter (.gte / .lte) instead of string equality.
+  const { data: commitGoals, error: goalsError } = await supabaseAdmin
+    .from("goals")
+    .select("id")
+    .eq("user_id", user.id)
+    .eq("unit", "commits")
+    .gte("period_start", weekStart)
+    .lte("period_start", weekEnd);
+
+  if (goalsError) {
+    return Response.json({ error: "Failed to fetch goals" }, { status: 500 });
+  }
+
+  if (!commitGoals || commitGoals.length === 0) {
+    return Response.json({ updated: 0, commitCount: 0 });
+  }
+
+  // ── 3. Count commits for the current week from GitHub ────────────────────
+  const ghRes = await fetch(
+    `${GITHUB_API}/search/commits?q=author:${session.githubLogin}+author-date:${weekStart}..${weekEnd}&per_page=100`,
+    {
+      headers: {
+        Authorization: `Bearer ${session.accessToken}`,
+        Accept: "application/vnd.github+json",
+      },
+      cache: "no-store",
+    }
+  );
+
+  if (!ghRes.ok) {
+    return Response.json({ error: "GitHub API error" }, { status: 502 });
+  }
+
+  const ghData = (await ghRes.json()) as { total_count: number };
+  const commitCount = ghData.total_count;
+
+  // ── 4. Update all commit-based goals with the real commit count ───────────
+  const now = new Date().toISOString();
+  const ids = commitGoals.map((g) => g.id);
+
+  const { error: updateError } = await supabaseAdmin
+    .from("goals")
+    .update({ current: commitCount, last_synced_at: now })
+    .in("id", ids);
+
+  if (updateError) {
+    return Response.json({ error: "Failed to update goals" }, { status: 500 });
+  }
+
+  return Response.json({ updated: ids.length, commitCount });
+}

src/app/api/metrics/contributions/route.ts

@@ -80,12 +80,7 @@ async function fetchContributionsForAccount(
       since.setDate(since.getDate() - days);
       const sinceStr = fromDate ?? toLocalDateStr(since);
 
-      let allItems: Array<{
-        sha: string;
-        html_url: string;
-        repository?: { full_name: string };
-        commit: { author: { date: string }; message: string };
-      }> = [];
+      let allItems: GitHubCommitSearchItem[] = [];
       const commitItems: CommitItem[] = [];
       let totalCount = 0;
       let page = 1;
@@ -122,12 +117,7 @@ async function fetchContributionsForAccount(
 
         const data = (await searchRes.json()) as {
           total_count: number;
-          items: Array<{
-            sha: string;
-            html_url: string;
-            repository?: { full_name: string };
-            commit: { author: { date: string }; message: string };
-          }>;
+          items: GitHubCommitSearchItem[];
         };
 
         if (page === 1) {

src/app/dashboard/settings/page.tsx

@@ -313,7 +313,7 @@ function SettingsPageContent() {
             className={`mb-6 rounded-xl border p-4 text-sm ${
               statusMessage.kind === "success"
                 ? "border-green-500/30 bg-green-500/10 text-green-400"
-                : "border-red-500/30 bg-red-500/10 text-red-400"
+                : "border-[var(--destructive-muted-border)] bg-[var(--destructive-muted)] text-[var(--destructive)]"
             }`}
           >
             {statusMessage.message}
@@ -492,7 +492,7 @@ function SettingsPageContent() {
           </div>
 
           {removeError && (
-            <div className="mt-4 rounded-lg border border-red-500/30 bg-red-500/10 p-3 text-sm text-red-400">
+            <div className="mt-4 rounded-lg border border-[var(--destructive-muted-border)] bg-[var(--destructive-muted)] p-3 text-sm text-[var(--destructive)]">
               {removeError}
             </div>
           )}
@@ -532,7 +532,7 @@ function SettingsPageContent() {
                       onClick={() => handleRemoveAccount(account.githubId)}
                       aria-label={`Remove ${account.githubLogin}`}
                       disabled={removingAccountId === account.githubId}
-                      className="rounded-lg border border-[var(--border)] px-4 py-2 text-sm font-medium text-[var(--card-foreground)] transition-colors hover:bg-red-500/10 hover:text-red-400 disabled:opacity-60"
+                      className="rounded-lg border border-[var(--border)] px-4 py-2 text-sm font-medium text-[var(--card-foreground)] transition-colors hover:bg-[var(--destructive-muted)] hover:text-[var(--destructive)] disabled:opacity-60"
                     >
                       {removingAccountId === account.githubId
                         ? "Removing..."

src/app/globals.css

@@ -21,6 +21,10 @@
   --control-hover: #cbd5e1;
   --tooltip: #ffffff;
   --tooltip-foreground: #0f172a;
+  --destructive: #ef4444;
+  --destructive-muted: rgba(239, 68, 68, 0.1);
+  --destructive-muted-border: rgba(239, 68, 68, 0.3);
+  --destructive-foreground: #ffffff;
 }
 
 .dark {
@@ -42,6 +46,10 @@
   --control-hover: #475569;
   --tooltip: #1e293b;
   --tooltip-foreground: #f8fafc;
+  --destructive: #f87171;
+  --destructive-muted: rgba(248, 113, 113, 0.1);
+  --destructive-muted-border: rgba(248, 113, 113, 0.3);
+  --destructive-foreground: #ffffff;
 }
 
 body {