Skip to content

Conversation

@thien-lm
Copy link

based on this issue:
Project-HAMi/HAMi#1196

i've check source code of NCCL and it use cuMemCreate frequently. So i tried to make Hami core count that ammount of mem.

@hami-robot
Copy link
Contributor

hami-robot bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thien-lm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot
Copy link
Contributor

hami-robot bot commented Jul 15, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 4ef030b add memory counter for virtual memory management

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hami-robot
Copy link
Contributor

hami-robot bot commented Jul 15, 2025

Welcome @thien-lm! It looks like this is your first PR to Project-HAMi/HAMi-core 🎉

@archlitchi
Copy link
Member

hi, please sign-off your commit and resolve the conflict, i'm ready to integrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants