Skip to content

Conversation

cho-m
Copy link
Contributor

@cho-m cho-m commented Aug 12, 2025

Issue

Fixes #7219

Used __has_include (since C++20 standard) though alternative would be BOOST_VERSION < 108900

Tasklist

Requirements / Relations

None

@cho-m cho-m mentioned this pull request Aug 12, 2025
41 tasks
@DennisOSRM
Copy link
Collaborator

consider also bumping the dependency.

@cho-m
Copy link
Contributor Author

cho-m commented Aug 25, 2025

consider also bumping the dependency.

Where are you referring to?


If CI, it doesn't look like MarkusJx/install-boost@v2 has 1.89.0 yet - https://github.com/MarkusJx/prebuilt-boost/blob/main/versions-manifest.json#L1881

boost_version: 1.85.0

and same thing for Conan: https://conan.io/center/recipes/boost?version=1.88.0

self.requires("boost/1.85.0")


For code, it should be backwards compatible as far as I can tell, so there shouldn't be any increase in minimum required Boost.

@DennisOSRM
Copy link
Collaborator

Thx for the clarification. Looks fine to merge as is and to bump the dependencies when they become available.

@DennisOSRM DennisOSRM merged commit a2e159d into Project-OSRM:master Aug 26, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with upcoming Boost 1.89.0
2 participants