Skip to content

Add RegExp 'global' option to Russian grammar rules #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add RegExp 'global' option to Russian grammar rules #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e282d6
Add RegExp 'global' option to Russian grammar rules
yuryleb Mar 16, 2018
7832e4b
Changelog entry for required global search option in grammar rules
yuryleb Mar 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ All notable changes to this project will be documented in this file. For change

## master

- Global search option is now required for all grammar rules. [#228] (https://github.com/Project-OSRM/osrm-text-instructions/pull/228)

## 0.14.0 2019-12-04

- Update Japanese localization, add named intersections. [#290](https://github.com/Project-OSRM/osrm-text-instructions/pull/290)
Expand Down
2 changes: 1 addition & 1 deletion languages/grammar/ru.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"meta": {
"regExpFlags": ""
"regExpFlags": "g"
},
"v5": {
"accusative": [
Expand Down
2 changes: 2 additions & 0 deletions test/grammar_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,8 @@ tape.test('verify grammar files structure', function(assert) {
Object.keys(languages.grammars).forEach((l) => {
var grammar = languages.grammars[l];

assert.ok(grammar.meta.regExpFlags.includes('g'), l + ' grammar has "g" regexp option');

assert.ok(grammar.v5, l + ' grammar has v5 version');

Object.keys(grammar.v5).forEach((g) => {
Expand Down