ps-realtor: full user interface overhaul additional fixes

[FrazzIe]

Overview

The main purpose of this pull request is to fix any issues that stood out to me during the testing of the user interface overhaul of ps-realtor.

Details

• Fix "imgs" key being set instead of "extra_imgs" when editing/adding or removing property images in ps-realtor through UpdateImgs event.
• Fix prematurely granting a potential buyer access to an MLO interior which uses ox-doorlock before the purchase has even been confirmed
• Remove an unused config option that has 0 references in the codebase ShowCustomizerWhenNoStartingApartment
  • If this is used somewhere please let me know and i'll revert it
• Change price column to be an unsigned integer, this prevents negative values being stored and doubles the available pricing amount
  • Don't think this is completely necessary, it's a database change, I've added sql script to be ran after the initial one which alters the column for existing setup, without migrations this is probably the best I can do.

UI Changes / Functionality

• No UI changes, shouldn't affect existing functionality other than allowing higher prices properties I guess.

Testing Steps

• Did you test the changes you made?

• Did you test core functionality of the script to ensure your changes do not regress other areas?

• Did you test your changes in multiplayer to ensure it works correctly on all clients?

• Run the additional sql script after the initial one (or apply to existing setup)

• Use ps-realtor to add/delete/change images

[RichardL007]

I've been doing some testing with this, hopefully these will be easy fixes:

• For MLOs using OX, showcase doesn't work (seems there's a mismatch between server and client variables passed, but no errors). I'd expect the doors to be unlocked for a period of time.

• After a house is deleted, outdoor furniture that was placed in the garden is still present.

• Additional keyholders can still unlock properties after their access is revoked (and confirmed so in the database).

I'll keep going. :-)

For tracking purposes, this is SpiffingRich from the PS Discord server.

[FrazzIe]

I've been doing some testing with this, hopefully these will be easy fixes:

• For MLOs using OX, showcase doesn't work (seems there's a mismatch between server and client variables passed, but no errors). I'd expect the doors to be unlocked for a period of time.
• After a house is deleted, outdoor furniture that was placed in the garden is still present.
• Additional keyholders can still unlock properties after their access is revoked (and confirmed so in the database).

I'll keep going. :-)

For tracking purposes, this is SpiffingRich from the PS Discord server.

are these issues present in the current ps-housing aswell? or are they caused by this pr?

because I don't see how this pr could have caused these issues at all.

[RichardL007]

I agree, I'll check. :-)

The new UI is lovely, by the way.

[MonkeyWhisper]

I've been doing some testing with this, hopefully these will be easy fixes:

• For MLOs using OX, showcase doesn't work (seems there's a mismatch between server and client variables passed, but no errors). I'd expect the doors to be unlocked for a period of time.
• After a house is deleted, outdoor furniture that was placed in the garden is still present.
• Additional keyholders can still unlock properties after their access is revoked (and confirmed so in the database).

I'll keep going. :-)

For tracking purposes, this is SpiffingRich from the PS Discord server.

Thank you for testing, I appreciate that!