Port DeltaV Winter Coats, More Clothing To Come

[WazuraWasTaken]

About the PR

So the normal Security Winter Coat is ugly as hell, and I miss my old sweater, so yea
As a sidenote, omg EE ported so many things from DeltaV
anyways this is just the first pr of the security drip stealing tm prs to come
Note:
The Greatcoat is a temporary addition to secoff, I intend to move it to sergeant, once I made them of course...

Why / Balance

Slight increase in armor, not too game breaking.

Technical details

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

• add: Ports Some of the winter coats from DeltaV
• tweak: Slightly Buff Security Winter Coat's Armor
• tweak: Security Armor Stat Standardized

[WazuraWasTaken]

wow that was easy, I may as well port more drip from there

[github-actions]

RSI Diff Bot; head commit e53682d merging into 208de95
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Clothing/OuterClothing/Wintercoats/armourergreatcoat.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon-open			Added
icon			Added
inhand-left			Added
inhand-right			Added
open-equipped-OUTERCLOTHING			Added
open-inhand-left			Added
open-inhand-right			Added

Resources/Textures/_DV/Clothing/OuterClothing/Wintercoats/corpsmancoat.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_DV/Clothing/OuterClothing/Wintercoats/detcoat.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_DV/Clothing/OuterClothing/Wintercoats/hosgreatcoat.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon-open			Added
icon			Added
inhand-left			Added
inhand-right			Added
open-equipped-OUTERCLOTHING			Added
open-inhand-left			Added
open-inhand-right			Added

Resources/Textures/_DV/Clothing/OuterClothing/Wintercoats/staseccoat.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/_DV/Clothing/OuterClothing/Wintercoats/stasecgreatcoat.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon-open			Added
icon			Added
inhand-left			Added
inhand-right			Added
open-equipped-OUTERCLOTHING			Added
open-inhand-left			Added
open-inhand-right			Added

Resources/Textures/_DV/Clothing/OuterClothing/Wintercoats/stasecsweater.rsi

State	Old	New	Status
equipped-OUTERCLOTHING			Added
icon			Added
inhand-left			Added
inhand-right			Added

Edit: diff updated after e53682d

[WazuraWasTaken]

GODDAMNIT THERE's SO MANY COOL SHIT, I WANT EM ALL

[WazuraWasTaken]

Also I have no clue, if I can even do this, is there like a no porting or something in these open source games? Or can I just go ham

[ukuleleman]

!!GREATCOATS!!

[NotActuallyMarty]

Comment your changes outside of omu namespaces and omu files

new coats should probably parent off of the existing ones for security and the like given we've got woundmed and any coats with armor are still gonna need things like traumadeductions and whatnot. take a look at our current coat armor for example, or if you're lazy just parent them as i said.

sidenote. probably remove the buff. It's not needed imo coats already get additional arm protection and in some cases groin protection which the normal armor vest does not provide, they should stay ever so slightly below the normal vest armor values due to that.

[NotActuallyMarty]

also yamllinter fail related and the like.

[WazuraWasTaken]

Comment your changes outside of omu namespaces and omu files

new coats should probably parent off of the existing ones for security and the like given we've got woundmed and any coats with armor are still gonna need things like traumadeductions and whatnot. take a look at our current coat armor for example, or if you're lazy just parent them as i said.

sidenote. probably remove the buff. It's not needed imo coats already get additional arm protection and in some cases groin protection which the normal armor vest does not provide, they should stay ever so slightly below the normal vest armor values due to that.

I originally used parenting from sec winters, but found that they still had the hood from the old sec armor, and this was my workaround.

Remove the winter coat buff?(also I think normal armor vest got groin protection last I checked)
What about the warden coat buffs, ie making them the same as hos’

(I gonna fix the coat tomorrow, and find the linter fail)

[NotActuallyMarty]

Comment your changes outside of omu namespaces and omu files
new coats should probably parent off of the existing ones for security and the like given we've got woundmed and any coats with armor are still gonna need things like traumadeductions and whatnot. take a look at our current coat armor for example, or if you're lazy just parent them as i said.
sidenote. probably remove the buff. It's not needed imo coats already get additional arm protection and in some cases groin protection which the normal armor vest does not provide, they should stay ever so slightly below the normal vest armor values due to that.

I originally used parenting from sec winters, but found that they still had the hood from the old sec armor, and this was my workaround.

Remove the winter coat buff?(also I think normal armor vest got groin protection last I checked) What about the warden coat buffs, ie making them the same as hos’

(I gonna fix the coat tomorrow, and find the linter fail)

rewrrite the toggleableclothing comp and point it to the ent for the hood

i.e.

- type: ToggleableClothing
    clothingPrototypes:
      head: ClothingHeadHatHoodWinterSec

Thats the sec winter coat one, you point it to the new one that you might want.

Sidenote that i realized as i wrote this cause i doublechecked, DV doesnt have this presumably cause they just changed the base textures or something. If you want diff hood you'd have to make a new ent for those hoods set its sprite to the new texture and then just do as i was saying, adding

- type: ToggleableClothing
    clothingPrototypes:
      head: NEWClothingHeadhatHoodWinterSecThatYouMade

its a lot more work and if you want to kill the hoods then yeah not parenting it is unfortunately the easiest way but make sure to replicate all the comps for the new coats too if you're doing that.

[WazuraWasTaken]

IT FINALLY PASSED ALL IT WAS A SPELLING MISTAKE I HATE MY LIFE

[NotActuallyMarty]

yaml looks mostly good will look at later