minor improvements

[gafo25]

Changes

Minor changes have been made to improve efficiency. These changes will not affect current projects and are primarily related to refactoring.

R/phs_colours.R

• First if conditional is the most used (when colourname is empty) It would be faster to avoid all the nested if else in function phs_colours
• Function unname generates a copy in memory, It is more efficient to use names(result) <- NULL to remove names
• If - else has been properly organised

R/phs_data.R

• The list phs_palettes was calling the phs_colours function; however, we already have access to the phs_colour_values object. Using it should be faster because the function contains several conditional checks.

[Moohan]

Some comments and suggestions. You should also add yourself to the description at a contributor (role = "ctb")

[Moohan]

We tend to use {cli} for phs packages per tidyverse style, in this case cli::cli_abort(...

[gafo25]

Can you give me more details about it?

[gafo25]

This suggestion may be considered in another PR

[Moohan]

Style guide - https://style.tidyverse.org/errors.html
{cli} - https://cli.r-lib.org/

For example, here: https://github.com/Public-Health-Scotland/phsmethods/blob/be6622f927a6eb0809d264f6461b6b951878aae7/R/extract_fin_year.R#L22

[Moohan]

I think {cli} will also need adding to imports usethis::use_package("cli")

Suggested change

	stop(msg)
	cli::cli_abort(c(
	"Some colours are not available.",
	x = "Unavailable colour{?s}: {.val {invalid_colours}}.",
	i = "Run {.fn phs_colours} to see all available colours."
	))