Consolidate Instrument Protocols #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjamin-Nussbaum
force-pushed
the
instrument-refactor
branch
from
bdda1e2 to
8dd09de
Compare
Benjamin-Nussbaum
force-pushed
the
instrument-refactor
branch
from
8dd09de to
f2227dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate
InstrumentProtocoltypes to allow proper type checking on the client side.This change removes the need for runtime asserts and other nonstandard checks.
How have these changes been tested?
Existing tests pass running
uv run scripts/test.