Fix one punch man not killing mobs in some cases#1762
Open
ukacimi wants to merge 1 commit intoPurpurMC:ver/1.21.11from
Open
Fix one punch man not killing mobs in some cases#1762ukacimi wants to merge 1 commit intoPurpurMC:ver/1.21.11from
ukacimi wants to merge 1 commit intoPurpurMC:ver/1.21.11from
Conversation
This happens if max_health attribute and entity's health are set higher than 9999F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens if
max_healthattribute and entity's health are set higher than9999F.The fix would be to always set the damage amount to the entity's health, so no matter its health, it will get killed.