Improve slurm DB API

pyslurm/core/error.pyx

@@ -27,6 +27,19 @@ from pyslurm cimport slurm
 cimport libc.errno
 
 
+def _check_modify_arguments(changes, **kwargs):
+    if changes is None and not kwargs:
+        raise ArgumentError("Nothing to change was provided")
+
+    if changes is not None and kwargs:
+        raise ArgumentError("Provide either a changes object or keyword arguments, not both")
+
+
+def _get_modify_arguments_for(cls, changes, **kwargs):
+    _check_modify_arguments(changes, **kwargs)
+    return changes or cls(**kwargs)
+
+
 def slurm_strerror(errno):
     """Convert a slurm errno to a string.
 
@@ -69,7 +82,15 @@ class PyslurmError(Exception):
     """The base Exception for all Pyslurm errors."""
 
 
-class RPCError(PyslurmError):
+class ClientError(PyslurmError):
+    pass
+
+
+class ServerError(PyslurmError):
+    pass
+
+
+class RPCError(ServerError):
     """Exception for handling Slurm RPC errors.
 
     Args:
@@ -100,12 +121,26 @@ class RPCError(PyslurmError):
         super().__init__(self.msg)
 
 
-def verify_rpc(errno):
+class InvalidUsageError(ClientError):
+    pass
+
+
+class ArgumentError(InvalidUsageError):
+    pass
+
+
+class NotFoundError(RPCError):
+    pass
+
+
+def verify_rpc(errno, msg=None):
     """Verify a Slurm RPC
 
     Args:
         errno (int):
             A Slurm error value
+        msg (str):
+            An optional message
     """
     if errno != slurm.SLURM_SUCCESS:
-        raise RPCError(errno)
+        raise RPCError(errno, msg)

pyslurm/db/__init__.py

@@ -19,7 +19,7 @@
 # with PySlurm; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-from .connection import Connection
+from .connection import Connection, connect
 from .step import JobStep, JobSteps
 from .stats import JobStatistics, JobStepStatistics
 from .job import (
@@ -44,3 +44,18 @@
     Association,
     AssociationFilter,
 )
+from .user import (
+    Users,
+    User,
+    UserFilter,
+)
+from .account import (
+    Accounts,
+    Account,
+    AccountFilter,
+)
+from .wckey import (
+    WCKeys,
+    WCKey,
+    WCKeyFilter,
+)

pyslurm/db/account.pxd

@@ -0,0 +1,108 @@
+#########################################################################
+# account.pxd - pyslurm slurmdbd account api
+#########################################################################
+# Copyright (C) 2025 Toni Harzendorf <toni.harzendorf@gmail.com>
+#
+# This file is part of PySlurm
+#
+# PySlurm is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+
+# PySlurm is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with PySlurm; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# cython: c_string_type=unicode, c_string_encoding=default
+# cython: language_level=3
+
+from libc.string cimport memcpy, memset
+from pyslurm cimport slurm
+from pyslurm.slurm cimport (
+    slurmdb_account_rec_t,
+    slurmdb_assoc_rec_t,
+    slurmdb_assoc_cond_t,
+    slurmdb_account_cond_t,
+    slurmdb_accounts_get,
+    slurmdb_accounts_add,
+    slurmdb_accounts_remove,
+    slurmdb_accounts_modify,
+    slurmdb_destroy_account_rec,
+    slurmdb_destroy_account_cond,
+    try_xmalloc,
+)
+from pyslurm.db.util cimport (
+    SlurmList,
+    SlurmListItem,
+    make_char_list,
+    slurm_list_to_pylist,
+    qos_list_to_pylist,
+)
+from pyslurm.db.tres cimport (
+    _set_tres_limits,
+    TrackableResources,
+)
+from pyslurm.db.connection cimport Connection, ConnectionWrapper
+from pyslurm.utils cimport cstr
+from pyslurm.db.qos cimport QualitiesOfService, _set_qos_list
+from pyslurm.db.assoc cimport Associations, Association, _parse_assoc_ptr
+from pyslurm.xcollections cimport MultiClusterMap
+from pyslurm.utils.uint cimport u16_set_bool_flag
+
+
+cdef class AccountAPI(ConnectionWrapper):
+    pass
+
+
+cdef class Accounts(dict):
+    cdef public:
+        Connection _db_conn
+
+
+cdef class AccountFilter:
+    cdef slurmdb_account_cond_t *ptr
+
+    cdef public:
+        with_assocs
+        with_deleted
+        with_coordinators
+        names
+        organizations
+        descriptions
+
+
+cdef class Account:
+    """Slurm Database Account.
+
+    Attributes:
+        name (str):
+            Name of the Account.
+        description (str):
+            Description of the Account.
+        organization (str):
+            Organization of the Account.
+        is_deleted (bool):
+            Whether this Account has been deleted or not.
+        association (pyslurm.db.Association):
+            This accounts association.
+    """
+    cdef:
+        slurmdb_account_rec_t *ptr
+
+    cdef readonly:
+        cluster
+
+    cdef public:
+        associations
+        coordinators
+        association
+        Connection _db_conn
+
+    @staticmethod
+    cdef Account from_ptr(slurmdb_account_rec_t *in_ptr)