Refactor and Update Library's code and fully Type-hint it #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to name all the changes I've made to this library but I think aiohttp may have used this library at some point or is currently using it. I am a contributor over there and I had the impression that I should try and help out with this library at some point in the future to keep the code up to date. But here's a rundown of what I've added and changed.
py.typedfilebytearrayfor better control over clearing results.MemoryErrorwas the best choice for that.__dealloc__as an aggressive measure to ensure objects are being freed correctly so that there is never a chance of a memory leak.build_extcommand class for this library that I have been using in most of my other resources and libraries that I own or maintain and you have my permission to use it as you wish. it has extra commands for helping other users with annotating over the cython code as well as compiling