-
Notifications
You must be signed in to change notification settings - Fork 54
Add linux aarch64 wheel support #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@PyYoshi, could you please take a look at this PR? Thanks. |
|
@PyYoshi , could you please share your feedback on this PR? Please let me know if any thing is missing here. Thanks. |
|
Now, I'm busy with work, so it's hard for me to review. Sorry for the late reply. I'm using act to debug this workflow on local env. |
.github/workflows/build-linux.yml
Outdated
| run: | | ||
| python -m pip install cibuildwheel~=1.8.0 | ||
| - uses: docker/setup-qemu-action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml
index 09c03d9..1332518 100644
--- a/.github/workflows/build-linux.yml
+++ b/.github/workflows/build-linux.yml
@@ -95,7 +95,7 @@ jobs:
run: |
python -m pip install cibuildwheel~=1.8.0
- - uses: docker/setup-qemu-action@v1
+ - uses: docker/setup-qemu-action@v1
name: Set up QEMU
- name: Checkout submodulesmissing one space at the beginning of the line.
please use yaml linter to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
@PyYoshi could you please review this PR? Thanks in advance. |
|
@PyYoshi could you please review this PR? |
|
Need aarch64 wheel too. |
|
@PyYoshi , could you please review this PR? Thanks in advance. |
|
@PyYoshi, could you please have a look at this PR? Thanks in advance. |
Added linux aarch64 wheel support.
Related to #70. @PyYoshi Please review the changes.