Skip to content

Conversation

@odidev
Copy link

@odidev odidev commented Mar 1, 2021

Added linux aarch64 wheel support.
Related to #70. @PyYoshi Please review the changes.

@odidev
Copy link
Author

odidev commented Apr 21, 2021

@PyYoshi, could you please take a look at this PR? Thanks.

@odidev
Copy link
Author

odidev commented May 12, 2021

@PyYoshi , could you please share your feedback on this PR? Please let me know if any thing is missing here. Thanks.

@PyYoshi
Copy link
Owner

PyYoshi commented Jun 2, 2021

Now, I'm busy with work, so it's hard for me to review.
I hope you will be patient with me.

Sorry for the late reply.


I'm using act to debug this workflow on local env.
It's going to be some time before feedback.

run: |
python -m pip install cibuildwheel~=1.8.0
- uses: docker/setup-qemu-action@v1
Copy link
Owner

@PyYoshi PyYoshi Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml
index 09c03d9..1332518 100644
--- a/.github/workflows/build-linux.yml
+++ b/.github/workflows/build-linux.yml
@@ -95,7 +95,7 @@ jobs:
         run: |
           python -m pip install cibuildwheel~=1.8.0
 
-     - uses: docker/setup-qemu-action@v1
+      - uses: docker/setup-qemu-action@v1
         name: Set up QEMU
 
       - name: Checkout submodules

missing one space at the beginning of the line.
please use yaml linter to check.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@odidev odidev force-pushed the odidev_cChardet branch from 02757e9 to 0bec63f Compare June 9, 2021 11:58
@odidev
Copy link
Author

odidev commented Jul 21, 2021

@PyYoshi could you please review this PR? Thanks in advance.

@odidev
Copy link
Author

odidev commented Oct 20, 2021

@PyYoshi could you please review this PR?

@Rongronggg9
Copy link

Need aarch64 wheel too.
aarch64 VPS is much more common now, resulting in the necessity of building aarch64 docker image. Unfortunately, using docker buildx to build aarch64 docker image on x86(-64) is slow, even getting more painful if some libs must be built locally.

@odidev
Copy link
Author

odidev commented Nov 17, 2021

@PyYoshi , could you please review this PR? Thanks in advance.

@odidev
Copy link
Author

odidev commented Apr 5, 2022

@PyYoshi, could you please have a look at this PR? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants