Skip to content

IPOPT test bug: version checking incorrect#3862

Merged
mrmundt merged 3 commits intoPyomo:mainfrom
mrmundt:ipopt-test-bug
Mar 6, 2026
Merged

IPOPT test bug: version checking incorrect#3862
mrmundt merged 3 commits intoPyomo:mainfrom
mrmundt:ipopt-test-bug

Conversation

@mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Feb 26, 2026

Fixes NA

Summary/Motivation:

I installed IPOPT 3.14 while I was refreshing my environment, and what do you know, we have a bug! We don't check the second item in this test, only the first, so this fixes it. I also removed some unused imports.

Changes proposed in this PR:

  • Fix version checking bug
  • Remove unused imports

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt requested a review from jsiirola February 26, 2026 17:31
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (bdb22dd) to head (38edf2c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3862   +/-   ##
=======================================
  Coverage   89.67%   89.68%           
=======================================
  Files         908      908           
  Lines      106735   106735           
=======================================
+ Hits        95717    95722    +5     
+ Misses      11018    11013    -5     
Flag Coverage Δ
builders 29.09% <ø> (+0.01%) ⬆️
default 85.96% <ø> (?)
expensive 35.51% <ø> (?)
linux 87.13% <ø> (-2.03%) ⬇️
linux_other 87.13% <ø> (ø)
oldsolvers 28.00% <ø> (+<0.01%) ⬆️
osx 82.04% <ø> (ø)
win 85.56% <ø> (+<0.01%) ⬆️
win_other 85.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrmundt mrmundt merged commit 7ad143c into Pyomo:main Mar 6, 2026
35 checks passed
@mrmundt mrmundt deleted the ipopt-test-bug branch March 6, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants