Update GHA TPL cache; resolve new test failures#3865
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3865 +/- ##
==========================================
+ Coverage 89.65% 89.68% +0.02%
==========================================
Files 908 908
Lines 106757 106735 -22
==========================================
+ Hits 95715 95726 +11
+ Misses 11042 11009 -33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blnicho
left a comment
There was a problem hiding this comment.
I have a couple (hopefully easy) questions
| else | ||
| curl --max-time 150 --retry 8 \ | ||
| -L $URL/idaes-solvers-windows-x86_64.tar.gz \ | ||
| $URL/idaes-lib-windows-x86_64.tar.gz > $IPOPT_TAR |
There was a problem hiding this comment.
We no longer need idaes-lib on Windows?
There was a problem hiding this comment.
I think the better question here is, "Did we ever actually need it in the first place?", and I think the answer is "no."
There was a problem hiding this comment.
I think there was a time when we did need it (we were distributing some "standard libraries" that are always present on *nix). I think at some point we started compiling things more statically, which cut out the need for the extra libraries (or we changed how things were packaged so that the libraries we needed for the solvers were bundled with the solvers). Either way, I don't think there is anything in idaes-lib that we need for Pyomo testing.
Fixes # .
Summary/Motivation:
This updates the GHA TPL caches. Sort of. We are updating GAMS to the almost-current version (52.5) because the current version (53.1) causes segfaults (at least under pytest). The updated versions led to some test errors that this PR also resolves:
While working on things, some other things were cleaned up:
download-extensionscommandcurlrcfor passing standard options to curltest-branchespython versions to get better coverage without adding testsNOTE: the intent is to let this PR build and generate the new caches, then we will update the PR to unpin GAMS (but not trigger the caches to be rebuilt).
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: