Skip to content

Refactor and fix on scroll #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caillou wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Refactor and fix on scroll #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c3f48cd
Replace deprecated `node-sass` package
caillou Mar 12, 2021
8d8fcac
Use destructuring assignment
caillou Mar 12, 2021
1589668
Make `addPixels` and `getOffsetBorderRadius` static
caillou Mar 12, 2021
16dc6a1
DRY code
caillou Mar 12, 2021
d0b0f46
Use class field declarations with arrow functions.
caillou Mar 12, 2021
096eac0
DOMTokenList.remove() accepts multiple parameters
caillou Mar 12, 2021
a57bc52
Move if-clause into the function.
caillou Mar 12, 2021
61444c5
Replace comment by readable code
caillou Mar 12, 2021
27d6d09
Add more tests for scroll event handlers
caillou Mar 12, 2021
e168885
Ensure scroll/resize handlers are only called when needed
caillou Mar 12, 2021
59c441d
Add missing semi-colons
caillou Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ module.exports = api => {
]
}
]
],
"plugins": [
[
"@babel/plugin-proposal-class-properties"
]
]
}
};
Loading