Add cext slots added since last update#15838
Conversation
While Qiskitgh-15778 is not yet merged, we don't have CI enforcement that the vtable slots are always completely up-to-date. Several PRs adding new C API functions merged between the merge-base of Qiskitgh-15761[^1] and `main` at its time of merge (and subsequently). This PR uses the machinery in Qiskitgh-15778 to bring the slots completely up-to-date. [^1]: 888c877: Add C API vtable to `pyext`
jakelishman
added
Changelog: None
|
One or more of the following people are relevant to this code:
|
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
This lgtm, we should definitely merge the linter pr before rc1 to make sure that nothing slips in by accident.
| #[cfg(feature = "addr")] | ||
| use qiskit_cext::circuit::*; | ||
|
|
||
| #[rustfmt::skip] // Don't wrap long lines so everything stays on one line for counting. |
There was a problem hiding this comment.
This skips all rustfmt rules for the annotated scope right? I couldn't find a way to just set a custom line length so I guess this is fine. Hopefully the formatting doesn't get too wonky.
There was a problem hiding this comment.
yeah - some of the register lines are too long right now, but no so long that rustfmt gives up on its own (like some of the transpiler-pass lines)
|
I've removed this from the merge queue for now, just because I want to check that it's all correct a bit closer to the finalisation time of 2.4.0rc1 rather than opening another fix-up PR. Hopefully nothing should change and then I'll enqueue it. |
|
Ok I just checked locally and this is up to date and accounts for all slots. |
3 participants
While gh-15778 is not yet merged, we don't have CI enforcement that the vtable slots are always completely up-to-date. Several PRs adding new C API functions merged between the merge-base of gh-157611 and
mainat its time of merge (and subsequently). This PR uses the machinery in gh-15778 to bring the slots completely up-to-date.Summary
Details and comments
The only other C API PR I'm aware of for 2.4 is #15361 - if that merges, it should include a slots update of its own.
Footnotes
888c877: Add C API vtable to
pyext↩