Implement Error::cause() and source() for BacktraceError#113
Open
tormol wants to merge 1 commit intoQuantumBadger:masterfrom
Open
Implement Error::cause() and source() for BacktraceError#113tormol wants to merge 1 commit intoQuantumBadger:masterfrom
tormol wants to merge 1 commit intoQuantumBadger:masterfrom
Conversation
Owner
|
Thanks for submitting this. If I remember correctly, those functions in the In principle this looks fine, it just needs formatting with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't notice
cause()wasn't coming from the Error trait, until I passed the error to a&dyn Error-taking function and was surprised thatcause()was suddenly returningNone.Is there a reason why it's implemented as an inherent method instead of as part of the Error trait?
I don't think a reference to a boxed trait object lets the caller do anything more than they could with a reference to a trait object.
I've ran most of the pre-commit commands, but the
--testspart ofcargo testandcargo test --no-default-featuresfails with:(On linux with wayland)