Skip to content

Conversation

@saces
Copy link
Contributor

@saces saces commented Sep 12, 2025

this produces prettier urls without '.html' at the end

this produces prettier urls without '.html' at the end
@marmarek
Copy link
Member

It may be a bit late for that...

While URLs may be nicer, I think this would break links that are already out there, no? Especially the whole QubesOS/qubesos.github.io#243

Any rename/link change needs to come with matching redirect from the old one.

@maiska
Copy link
Contributor

maiska commented Sep 12, 2025

I wanted to test this out, @parulin also made the suggestion, I had some weird stuff locally I think with auto-build and did not have the time to look into this, and low prio, but coming I can and also prepare a redirects PR to qubesos.github.io.
It will take time, still low prio imho :)

@parulin
Copy link
Contributor

parulin commented Sep 12, 2025

I think it is too late now? All the current links with .html have to be redirected to the "clean links" and if it takes too much time, all the links containing anchors will be lost again.

@maiska
Copy link
Contributor

maiska commented Sep 12, 2025

I think it is too late now? All the current links with .html have to be redirected to the "clean links" and if it takes too much time, all the links containing anchors will be lost again.

no, i don't think so. there should not be anchors in the redirects, and if it is sufficiently tested and run by the link checker in rst itself we should be good. i do not see a lot of overhead here, but it will be approached at a slow pace and testing is needed

@parulin
Copy link
Contributor

parulin commented Sep 13, 2025

I think it is too late now? All the current links with .html have to be redirected to the "clean links" and if it takes too much time, all the links containing anchors will be lost again.

no, i don't think so. there should not be anchors in the redirects, and if it is sufficiently tested and run by the link checker in rst itself we should be good. i do not see a lot of overhead here, but it will be approached at a slow pace and testing is needed

Sorry, I wasn't clear. I had the forum in mind, or any external source: any link containing an anchor is lost.

I.e.: https://www.qubes-os.org/doc/glossary/#qube will redirect to https://doc.qubes-os.org/en/latest/user/reference/glossary.html, not https://doc.qubes-os.org/en/latest/user/reference/glossary.html#qube

So, moving again from https://doc.qubes-os.org/en/latest/user/reference/glossary.html to https://doc.qubes-os.org/en/latest/user/reference/glossary/ will have the same effect.

@maiska
Copy link
Contributor

maiska commented Sep 13, 2025

I think it is too late now? All the current links with .html have to be redirected to the "clean links" and if it takes too much time, all the links containing anchors will be lost again.

no, i don't think so. there should not be anchors in the redirects, and if it is sufficiently tested and run by the link checker in rst itself we should be good. i do not see a lot of overhead here, but it will be approached at a slow pace and testing is needed

Sorry, I wasn't clear. I had the forum in mind, or any external source: any link containing an anchor is lost.

I.e.: https://www.qubes-os.org/doc/glossary/#qube will redirect to https://doc.qubes-os.org/en/latest/user/reference/glossary.html, not https://doc.qubes-os.org/en/latest/user/reference/glossary.html#qube

So, moving again from https://doc.qubes-os.org/en/latest/user/reference/glossary.html to https://doc.qubes-os.org/en/latest/user/reference/glossary/ will have the same effect.

There is a possible solution to this: https://github.com/sphinx-doc/sphinxext-rediraffe

Let this be tackled in due time though. I would not like a discussion that needs time, and i cannot take the time to research and properly involve

@parulin
Copy link
Contributor

parulin commented Sep 14, 2025

So, moving again from https://doc.qubes-os.org/en/latest/user/reference/glossary.html to https://doc.qubes-os.org/en/latest/user/reference/glossary/ will have the same effect.

Never mind, I suppose that we will move from /latest/ to /stable/ URLs in the future so please ignore my previous comment :)

@marmarek
Copy link
Member

Look what I found in RTD settings:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants