Conversation
Hello, If tugtainer have to use http_proxy to reach internet, aiohttp need to be able to read system variable (http_proxy) https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support This is native on requests but not on aiohttp .. aio-libs/aiohttp#2963 Co-authored-by: Gael RICHIER <grichier@scaleway.com>
) ## Problem When Tugtainer recreates a container that was originally bound to a specific IP address (e.g. `-p 10.0.0.5:443:443`), the recreated container binds to `0.0.0.0:443` instead. This causes port conflicts when another service on the same host is already listening on that port on a different IP. In our case, we have two services that both need port 443 but on different IPs: - Service A bound to `10.0.0.5:443` - Service B bound to `10.0.0.10:443` Every time Tugtainer updates Service A, it gets recreated on `0.0.0.0:443`, conflicting with Service B, and fails to start. ## Root Cause `map_port_bindings_to_list()` reads `entry.host_port` from Docker's inspect data but ignores `entry.host_ip` entirely. The resulting tuple `(host_port, container_port, proto)` has no IP information, so Docker defaults to `0.0.0.0`. ## Fix When `host_ip` is present, prepend it to `host_port` (e.g. `"10.0.0.5:443"`), which Docker CLI correctly interprets as an IP-specific binding via `-p 10.0.0.5:443:443/tcp`. Containers without a specific IP binding are unaffected — they continue to use `0.0.0.0` as before. --------- Co-authored-by: VAC <vac@vacs-mac-mini.localdomain>
+ fixed images page loading (NG02100) + fixed app loading with some locales Closes #82
+ use component suffix + added suffix to angular.json + added vscode settings for auto format on save
+ moved files from entities to features respective directories + moved files from entities to shared
+ removed circular icon from containers / check all / check all hosts buttons Closes #123
+ added paho-mqtt dependency Closes #128
+ fixed issue with new migrations generation (import models to alembic env)
+ added setting + added pull before remote manifest request if enabled Closes #114
+ added setting + added delays between pull/manifest/etc Closes #116
+ fixed issue that scheduled check job was including all containers, now it includes selected only Related to #121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.