Skip to content

Conversation

RichLogan
Copy link
Collaborator

Ensure that camera formats fallback correctly when requests cannot be fulfilled exactly. The logic currently here is that a request for a higher resolution will always go through if possible, but a request for a higher frame rate that would lower resolution will not (e.g If you request 1080p60 and 4k30 you'll get 4k30).

If no exact match format can be found we do nothing. If there was never any match, you'll just be in the camera's default format.

Copy link
Contributor

@GhostofCookie GhostofCookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, though I wonder if there is a shorter way in swift that we could check for our ideal format parameters, and pick the one that matches the most params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants