fix: Correct file ignore check for node_modules #532
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where all node_modules and non-ts(x) files are linted even if they're explictly ignored by eslint config.
Also correcting file path check on Windows.
#528 fixed most of our problems running on Windows. Unfortunately, it didn't seem to quite fix the code that ignores linting for node_modules.
After some investigation it turns out on Windows, the
checkFileToBeIgnoredmethod sometimes receives files as standard Windows paths (\) but sometimes with forward slashes.This should fix the issue properly. Apologies to @artola for contributing the dodgy fix to your PR 🙂