-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: handle case-insensitive path comparison in glob tool on Windows #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xuewenjie123
wants to merge
3
commits into
main
Choose a base branch
from
fix/glob-windows-casing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📋 Review SummaryThis PR addresses a Windows-specific issue where file path comparisons in the GlobTool were failing due to case sensitivity differences in drive letter casing. The solution introduces path normalization for Windows platforms to ensure consistent comparison regardless of drive letter casing. 🔍 General Feedback
🎯 Specific Feedback🟢 Medium
🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #668
Problem:
On Windows, file paths are case-insensitive but case-preserving. The glob library often returns canonical paths with uppercase drive letters. If the VS Code workspace or target directory was opened using a lowercase drive letter, the strict string comparison (using Set.has()) in the filtering logic would fail, resulting in "No files found" even when files matched the pattern.
Solution:
Introduced a normalizePathForComparison helper in GlobTool.
On Windows (process.platform === 'win32'), paths are now normalized to lowercase before being added to the filter set or checked against it.
This ensures that file matching is robust against drive letter casing differences.
This PR fixes an issue where GlobTool would fail to find files on Windows if the drive letter casing differed between the workspace path and the paths returned by the glob library (e.g., c:\project vs C:\project).
Related Issue:
Fixes #668