Rev data source#2
Open
LandryNorris wants to merge 133 commits into
Open
Conversation
These windows incorrectly had menu bars rendered on Linux and Windows
Based on Apple's HIG
Includes AdvantageKit, DataLog, and DS data.
Some new users don't realize that the line graph and timeline can be zoomed, which can lead to confusion. This PR adds subtle help text in each place when the app is opened for the first time.
Mirrors the implementation in the desktop app to prevent format mismatches.
SwerveModuleVelocity and ChassisVelocities are now supported. The user-facing object for the latter is now called "Robot Velocities" for clarity.
jfabellera
force-pushed
the
feature/rev-data-source
branch
from
a64e295 to
249d9f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is opened against our fork intentionally for now. I will change it to the upstream when it is ready