pkg/pkg.mk: fix sparse checkout initialization#22113
pkg/pkg.mk: fix sparse checkout initialization#22113crasbe wants to merge 2 commits intoRIOT-OS:masterfrom
Conversation
The sparse checkout was not initialized properly which resulted in some systems fetching the full folders (cone mode) instead of the selected files only (non-cone mode). This fixes a regression introduced in RIOT-OS#22039.
crasbe
added
Type: bug
github-actions
bot
added
Area: build system
|
I tried to understand the referenced issue and after reading through the git doc it seems like I'm not a git expert when it comes to such advanced stuff but is there any other solution by chance? |
Not really, because cone mode only supports full directories, which defeats the purpose for the vendor header stuff. Fetching the full directory would be 200+MB whereas fetching only the required headers is ~15MB. Apparently non-cone mode is deprecated, but there are no plans to remove it. It's just meant to discourage people from using it. But as long as there's no viable alternative, I don't know what else to do. Mind you, we already were using non-cone mode, just implicitly not explicitly and that's why it broke on some machines and worked on others. |
|
When running this within the docker I get ``` |
3 participants
Contribution description
The sparse checkout was not initialized properly which resulted in some systems fetching the full folders (cone mode) instead of the selected files only (non-cone mode).
This fixes a regression introduced in #22039.
It only appeared on some machines which seems to depend on global git settings, which is why it neither happened on my machine nor on
skyleaf.Testing procedure
Testing was done by @RainbowSimon here: #22111 (comment)
Unfortunately I can't reproduce it on my machine.
Issues/PRs references
Fixes #22111.
Regression introduced in #22039.