[rocprofiler-sdk] Handle validate tests script when Blit kernels are used for mem copies#3241
Open
venkat1361 wants to merge 3 commits intodevelopfrom
Open
[rocprofiler-sdk] Handle validate tests script when Blit kernels are used for mem copies#3241venkat1361 wants to merge 3 commits intodevelopfrom
venkat1361 wants to merge 3 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the rocprofv3 tracing validation script to be more tolerant of ROCr using rocclr “blit” kernels for memcpy operations, which can change the expected number and type of trace records.
Changes:
- Relax kernel-dispatch count assertions and skip specific rocclr blit-kernel entries in kernel trace validation.
- Relax memory-copy trace expectations from “exactly two directions” to “at least one”, and validate direction/agent-type consistency via iteration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
venkat1361
force-pushed
the
users/venkat1361/fix-psdb-tests
branch
from
597a361 to
2185be1
Compare
itrowbri
approved these changes
Feb 13, 2026
| kernel_dispatch_data = data["buffer_records"]["kernel_dispatch"] | ||
| assert len(kernel_dispatch_data) == 1 | ||
| # Blit kernel maybe recorded, when greater than 1. | ||
| assert len(kernel_dispatch_data) >= 1 |
Contributor
There was a problem hiding this comment.
As we exepcted that kernel_dispatch_data only consisted of one valid kernel, but it can actually be more due to blit kernels?
| assert len(memory_copy_input_data) > 0 | ||
|
|
||
| directions = set() | ||
| valid_directions = ("MEMORY_COPY_HOST_TO_DEVICE", "MEMORY_COPY_DEVICE_TO_HOST") |
Contributor
There was a problem hiding this comment.
Why not just make this a set here instead of creating an expected_directions set from this variable later?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix test failures in http://rocm-ci.amd.com//job/rocm-tests/40057/testReport/junit/tests/TestSuite/test_rocprofilerSdk/
Technical Details
JIRA ID
SWDEV-578807
Test Plan
Test Result
Submission Checklist